nridge added a comment. Thanks for the patch!
Could you add some tests to clang-tools-extra/clangd/unittests/SemanticHighlightingTests.cpp as well? I wrote a bit about how the tests work on Discord, copying for convenience: > In SemanticHighlightingTests.cpp, we have code inputs which are annotated > with the highlighting kinds (and in some tests, modifiers) that various > tokens should get. > You can build the test suite with `ninja ClangdTests` > Then you can run an individual test case using a command like > `./tools/clang/tools/extra/clangd/unittests/ClangdTests > --gtest_filter=SemanticHighlighting.MyTestName` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119077/new/ https://reviews.llvm.org/D119077 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
