jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.
LG, as part of the patch set, and given the runtime test for coverage.
Some nits.
================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:8154
+ for (auto TI = OpenMPTCRange.first, TE = OpenMPTCRange.second; TI != TE;
+ ++TI) {
+ const ToolChain *TC = TI->second;
----------------
Nit: maybe `for (auto &TI : make_range(OpenMPTCRange.first,
OpenMPTCRange.second))`
================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:8180
+ CmdArgs.push_back(Args.MakeArgString(Twine("-opt-level=O") + OOpt));
+ }
+ }
----------------
I thought there is a helper somewhere that does this translation, isn't there?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116975/new/
https://reviews.llvm.org/D116975
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
