MaskRay added a comment.

Hope that someone familiar with CMake can take a look.

> As currently implemented llvm-driver contains dsymutil, llvm-ar, 
> llvm-cxxfilt, llvm-objcopy, and clang (if clang is included in the build).

I think either (bundled clang+binary utilities) or (bundled lld+binary 
utilities) is fine.
Some folks are interested in PGO builds for clang and lld. Not bundling clang 
and lld together can make both optimized.
The performance of binary utilities likely does not matter that much, so 
bundling them with either clang or lld should be fine.

---

I have tried the latest diff but 
`-DLLVM_ENABLE_PROJECTS='clang;clang-tools-extra;flang;lldb;lld;compiler-rt;openmp;mlir;cross-project-tests'
 -DLLVM_TOOL_LLVM_DRIVER_BUILD=on` gives me:

  CMake Error at cmake/modules/LLVM-Config.cmake:110 (target_link_libraries):   
              
    The keyword signature for target_link_libraries has already been used with  
              
    the target "obj.dsymutil".  All uses of target_link_libraries with a target 
              
    must be either all-keyword or all-plain.                                    
              
                                                                                
              
    The uses of the keyword signature are here:                                 
                                                                
                                                                                
              
     * cmake/modules/AddLLVM.cmake:897 (target_link_libraries)                  
              
                                                                                
              
  Call Stack (most recent call first):                                          
              
    cmake/modules/LLVM-Config.cmake:95 (explicit_llvm_config)                   
              
    cmake/modules/AddLLVM.cmake:898 (llvm_config)                               
                                                                
    cmake/modules/AddLLVM.cmake:1264 (add_llvm_executable)                      
                                                                
    tools/dsymutil/CMakeLists.txt:21 (add_llvm_tool)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109977/new/

https://reviews.llvm.org/D109977

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to