aaron.ballman added a comment. In D114483#3281718 <https://reviews.llvm.org/D114483#3281718>, @aaron.ballman wrote:
> In D114483#3281714 <https://reviews.llvm.org/D114483#3281714>, @zahiraam > wrote: > >> In D114483#3280905 <https://reviews.llvm.org/D114483#3280905>, @MaskRay >> wrote: >> >>> Closed by 8ba9c794feb30cd969b9776c39873def10c51bff >>> <https://reviews.llvm.org/rG8ba9c794feb30cd969b9776c39873def10c51bff>. >>> >>> If the commit message contained `Differential Revision:`, the differential >>> would be closely automatically when you pushed it to the git repo. >>> Please ensure the tag is contained next time. `arc diff` adds this tag >>> automatically. >>> >>> `clang/include/clang/Basic/AttrDocs.td` had some formatting issues and >>> caused (`-DLLVM_ENABLE_SPHINX=ON`) `ninja docs-clang-html` to fail. >>> I fixed it. Please test this build target for `.rst` and `AttrDocs.td` >>> changes. >> >> @MaskRay OK thanks. I see other clang-format issues. Should those be fixed >> too? > > The issues aren't from clang-format, they're from the RST file contents not > building in sphinx due to formatting issues in AttrDocs.td. > > https://lab.llvm.org/buildbot/#/builders/92/builds/20791/steps/5/logs/stdio > https://lab.llvm.org/buildbot/#/builders/92/builds/21098/steps/5/logs/stdio > > are two such examples that stem from your patch. Basically, you have to build > the attribute documentation (converting AttrDocs.td into > AttributeReference.rst) and then build the sphinx documents locally to ensure > you're not introducing new issues. Or, you can try to speculatively fix based > on the errors the bot gives you, but sometimes those errors are super cryptic > and take multiple tries to fix (like the "can't lex as C++" one above), which > is why trying to reproduce locally is a good first step. I've pushed a fix for it in a10ff373ddfa82a67c580a87f6258aa6ab8dd595 <https://reviews.llvm.org/rGa10ff373ddfa82a67c580a87f6258aa6ab8dd595> and the sphinx builder is happy again. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114483/new/ https://reviews.llvm.org/D114483 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
