dblaikie added a comment.

I didn't find any mention of Darwin in RecordLayoutBuilder, which surprised me 
- I thought maybe Darwin was using the ClangABICompat to express its ABI 
compatibility requirements (which would sort of be handy rather than having to 
test multiple target features, for those targets that define their ABI by 
Clang's behavior - though I guess even those targets might be willing to take 
some ABI breaks against themselves sometimes (looks like they have, 
historically - looking at the other ClangABICompat values and where/how they're 
tested - I don't see target tests against Darwin and PS4 for all of them)) but 
doesn't look like it.

So - should I be testing Darwin/MacOS/something support differently than I have?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117616/new/

https://reviews.llvm.org/D117616

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to