MaskRay added a comment. In D117744#3273521 <https://reviews.llvm.org/D117744#3273521>, @dblaikie wrote:
> In D117744#3273481 <https://reviews.llvm.org/D117744#3273481>, @MaskRay wrote: > >> In D117744#3273463 <https://reviews.llvm.org/D117744#3273463>, @dblaikie >> wrote: >> >>> I don't especially feel that removing low-cost features like this is a >>> great idea (the benefit to cleaning up a small amount of code compared to >>> the (albeit small) risk of breaking users doesn't seem high value to me), >>> but sure - give it a go. >> >> Thanks:) >> >> This is to ensure that there are no producers: then we can do something more >> ambitious, like removing assembler support:) >> >> Driver change is a good start because if someone has justifiable complaint, >> the change can be relatively easily reversed without churn to the underlying >> implementation. >> >> It will also make future removal of .zdebug from ld.lld justifiable. > > Yeah, I appreciate the desire, but it doesn't seem especially burdensome to > support (since we'll still have support for the SHF_COMPRESSED style and it's > not a lot of code on top of that to support the zdebug style) so I don't see > as much value in making these changes, but that's OK. The issue with `.zdebug` is the section name. When iterating over input sections (which may cost ld.lld 0.4% time, the ratio will go up if we support parallel symbol table initialization), not needing to scan section names (different places from the section metadata) will improve a bit. Yeah, it's saving on some very minor stuff, I know. > Oh, one thing: would probably be good to make two separate commits, one for > -gz and one for the --compress-debug-sections OK Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117744/new/ https://reviews.llvm.org/D117744 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
