dgoldman marked 2 inline comments as done.
dgoldman added inline comments.

================
Comment at: clang/lib/Lex/HeaderSearch.cpp:1043
 
     // If this file is found in a header map and uses the framework style of
     // includes, then this header is part of a framework we're building.
----------------
cishida wrote:
> sammccall wrote:
> > The comment here explicitly say "in a header map and". Unfortunately it 
> > doesn't say why, and I don't know enough to guess.
> nit/reminder: This should be updated now 
Updated, LMK if you have any suggestions on the wording here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117830/new/

https://reviews.llvm.org/D117830

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to