MaskRay added a comment.
I don't know the AVR specific thing but having this toolchain-specific
diagnostic in the toolchain-specific file seems the right direction.
================
Comment at: clang/lib/Driver/ToolChains/AVR.cpp:418
+ // a '.s' suffix.
+ for (unsigned I = 0; I < DriverArgs.size(); I++) {
+ StringRef Arg(DriverArgs.getArgString(I));
----------------
https://llvm.org/docs/CodingStandards.html#don-t-evaluate-end-every-time-through-a-loop
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118095/new/
https://reviews.llvm.org/D118095
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
