LiuChen3 added inline comments.

================
Comment at: clang/lib/Headers/cpuid.h:199
 /* Features in %eax for leaf 7 sub-leaf 1 */
+#define bit_AVXVNNI       0x00000008
 #define bit_AVX512BF16    0x00000020
----------------
craig.topper wrote:
> RKSimon wrote:
> > @liuchen3 https://github.com/llvm/llvm-project/issues/53392 reports this 
> > should be 0x00000010?
> Maybe we should start writing these as 1 << 4. This is not the first shifted 
> by one issue we've had in this file.
It my fault. I have a fix here: https://reviews.llvm.org/D118103 .


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89105/new/

https://reviews.llvm.org/D89105

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to