bader accepted this revision. bader added a comment. This revision is now accepted and ready to land.
LGTM, just one suggestion. It would be great to get @aaron.ballman approve too. ================ Comment at: clang/lib/Sema/SemaDecl.cpp:16690 + diag::err_sycl_special_type_missing_init_method); + } } ---------------- I think we might want to check that there is only one member function with `__init` name to avoid ambiguity with building kernel parameters. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114483/new/ https://reviews.llvm.org/D114483 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits