glaubitz added inline comments.

================
Comment at: clang/lib/Driver/ToolChains/Solaris.cpp:138-139
+    if (getToolChain().getTriple().getArch() == llvm::Triple::sparc) {
+      CmdArgs.push_back(getAsNeededOption(getToolChain(), true));
+      CmdArgs.push_back("-latomic");
+      CmdArgs.push_back(getAsNeededOption(getToolChain(), false));
----------------
Note, this will only work when `__atomic_compare_exchange()` is being used as 
``__sync_val_compare_and_swap_8` is not implemented by `libatomic` in gcc, see: 
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63368 (Unless this has changed 
recently).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118021/new/

https://reviews.llvm.org/D118021

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D118021:... Rainer Orth via Phabricator via cfe-commits
    • [PATCH] D11... John Paul Adrian Glaubitz via Phabricator via cfe-commits
    • [PATCH] D11... John Paul Adrian Glaubitz via Phabricator via cfe-commits
    • [PATCH] D11... Joerg Sonnenberger via Phabricator via cfe-commits
    • [PATCH] D11... John Paul Adrian Glaubitz via Phabricator via cfe-commits
    • [PATCH] D11... Rainer Orth via Phabricator via cfe-commits
    • [PATCH] D11... John Paul Adrian Glaubitz via Phabricator via cfe-commits
    • [PATCH] D11... Rainer Orth via Phabricator via cfe-commits
    • [PATCH] D11... John Paul Adrian Glaubitz via Phabricator via cfe-commits
    • [PATCH] D11... Rainer Orth via Phabricator via cfe-commits
    • [PATCH] D11... Rainer Orth via Phabricator via cfe-commits
    • [PATCH] D11... John Paul Adrian Glaubitz via Phabricator via cfe-commits
    • [PATCH] D11... John Paul Adrian Glaubitz via Phabricator via cfe-commits

Reply via email to