JonChesterfield added a comment.

The asm variable used by rocm aomp is zero overhead, needs no compiler support 
and works exactly as one would wish under inlining or code elimination. The 
main argument against that approach seems to be it's an abi break, much like 
this patch was, and that it is per-code-object instead of per-function, which I 
still think is a benefit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115283/new/

https://reviews.llvm.org/D115283

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to