curdeius added a comment.
I'd like to see the refactor of the parts repeated from UnwrappedLineParser.
No comments otherwise.
================
Comment at: clang/lib/Format/DefinitionBlockSeparator.cpp:134
+ OperateIndex + 1 < Lines.size()) {
+ // UnwrappedLineParser's recognition of free-standing macro like
+ // Q_OBJECT may also recognize some uppercased type names that may be
----------------
ksyx wrote:
> HazardyKnusperkeks wrote:
> > Shouldn't we set a type for such cases instead of repeating the detection
> > code here?
> Here I actually did a few more checks to limit the impact to the minimum but
> I am happy to do that if that's necessary.
> Shouldn't we set a type for such cases instead of repeating the detection
> code here?
:+1:
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117520/new/
https://reviews.llvm.org/D117520
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
