LegalizeAdulthood added a comment.

In D117306#3245915 <https://reviews.llvm.org/D117306#3245915>, @njames93 wrote:

> How does this check play with the `modernize-make-shared` check?

Wouldn't it be orthogonal?

This check looks for existing `make_shared` usages, whereas
modernize-make-shared adds new `make_shared` usages from
`new shared_ptr` usages.  I wouldn't expect `modernize-make-shared`
to generate mismatched scalar/array `shared_ptr` instances.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117306/new/

https://reviews.llvm.org/D117306

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to