JackAKirk added a comment. In D116673#3241721 <https://reviews.llvm.org/D116673#3241721>, @tra wrote:
> In D116673#3237873 <https://reviews.llvm.org/D116673#3237873>, @JackAKirk > wrote: > >>>> I can land the patch on your behalf. Are you OK to use the name/email in >>>> this patch or do you prefer to use a different email for the LLVM commit? >> >> Thanks very much. Yes the name/email in the patch is fine. > > Note for the future. It would make it easier to land the patch if it was > submitted to phabricator as a git patch, according to the instructions here: > https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface > > Review tracker would then include info about relevant base commit, author, > commit message, etc. and it can be easily applied with `arc patch` to my > tree. Using plain diff requires a bit of extra manual work to transfer all of > that from the review tracker to the git commit. OK thanks for the tip. I'll make sure to submit it to Phabricator as a git patch next time. Thanks again for making the commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116673/new/ https://reviews.llvm.org/D116673 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
