ymandel accepted this revision. ymandel added a comment. This revision is now accepted and ready to land.
Bravo! This is an impressively thorough job. Thanks for pushing through to completion! ================ Comment at: clang-tools-extra/clang-tidy/bugprone/StringviewNullptrCheck.cpp:263 + auto HandleConstructorInvocation = + makeRule(cxxConstructExpr(hasAnyArgument(ignoringImpCasts( + BasicStringViewConstructingFromNullExpr)), ---------------- precede with `argumentCountIs(1)`? Also, please comment on choice of `hasAnyArgument` (copying what you wrote in the patch description is fine). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115121/new/ https://reviews.llvm.org/D115121 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
