ahoppen added a comment. I suppose the idea is that all `Module` creations should go through `makeModule`, right? In that case I think we should either
- make the `Module` constructor private and `ModuleMap` a friend of `Module` - or at least add a doc comment to the `Module` constructor that says `Module`s should only be created using `ModuleMap::makeModule`. Or are there other places that also create `Module`s but are not supposed to go through `ModuleMap::makeModule`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116751/new/ https://reviews.llvm.org/D116751 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
