Ericson2314 marked 2 inline comments as done. Ericson2314 added a comment. Mark some old threads done.
================ Comment at: llvm/cmake/modules/CMakeLists.txt:3 -set(LLVM_INSTALL_PACKAGE_DIR lib${LLVM_LIBDIR_SUFFIX}/cmake/llvm) +set(LLVM_INSTALL_PACKAGE_DIR lib${LLVM_LIBDIR_SUFFIX}/cmake/llvm CACHE STRING "Path for CMake subdirectory (defaults to 'cmake/llvm')") set(llvm_cmake_builddir "${LLVM_BINARY_DIR}/${LLVM_INSTALL_PACKAGE_DIR}") ---------------- Ericson2314 wrote: > compnerd wrote: > > Why is this variable being put into the cache now? > I wanted all the installation dirs to be in there for consistency (c.f. Did > the same for compiler-rt in D105765). > > FWIW I have a yet-unposted commit I want to improve a bit to make it more > genuinely user-configurable too (we want the CMake with the headers so it > need not be installed runtime) I see I put this back for now, that's good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100810/new/ https://reviews.llvm.org/D100810 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits