owenpan added a comment.

In D116318#3211689 <https://reviews.llvm.org/D116318#3211689>, 
@HazardyKnusperkeks wrote:

> I'm against that patch.
>
>> Don't pay for what you don't use.
>
> We should not put the size check into every call.

That's what you must do now **without **this patch, which will fix the problem. 
I should be able to just call `getPreviousToken()` without having to first 
check `Position > 0`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116318/new/

https://reviews.llvm.org/D116318

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to