[PATCH] D116161: [Clang] Add an overload for emitUnaryBuiltin.

[Florian Hahn via Phabricator via cfe-commits]

fhahn added inline comments.


================
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:3137
     else
       Result = Builder.CreateUnaryIntrinsic(llvm::Intrinsic::fabs, Op0, 
nullptr,
                                             "elt.abs");
----------------
Should also be used here?


================
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:3193
     Value *Op0 = EmitScalarExpr(E->getArg(0));
     Value *Result = Builder.CreateUnaryIntrinsic(
         GetIntrinsicID(E->getArg(0)->getType(), Op0->getType()), Op0, nullptr,
----------------
Should also be used here?



================
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:3212
     Value *Op0 = EmitScalarExpr(E->getArg(0));
     Value *Result = Builder.CreateUnaryIntrinsic(
         GetIntrinsicID(E->getArg(0)->getType(), Op0->getType()), Op0, nullptr,
----------------
Should also be used here?



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116161/new/

https://reviews.llvm.org/D116161

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits