luismarques added a comment. I think this would benefit from increased test coverage, namely to show that the mattr command-line options are properly handled. Some possible ideas:
- Tests with the correct extension versions (maybe add a test file that exercises the version for all extensions). - Tests that show an error message with unsupported versions. - A test that shows that something like mattr=+m,+m2p1 is allowed (or not). Nit: fix the lint / no new line warnings. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115921/new/ https://reviews.llvm.org/D115921 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
