ChuanqiXu created this revision.
ChuanqiXu requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This patch adds two test about template class instantiation in transitively
imported module. They are used as pre-commit tests for successive patches.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D116097
Files:
clang/test/Modules/Inputs/module-transtive-instantiation/Templ.cppm
clang/test/Modules/Inputs/module-transtive-instantiation/bar.cppm
clang/test/Modules/module-transtive-instantiation-2.cpp
clang/test/Modules/module-transtive-instantiation.cpp
Index: clang/test/Modules/module-transtive-instantiation.cpp
===================================================================
--- /dev/null
+++ clang/test/Modules/module-transtive-instantiation.cpp
@@ -0,0 +1,13 @@
+// RUN: rm -rf %t
+// RUN: mkdir -p %t
+// RUN: %clang -std=c++20 %S/Inputs/module-transtive-instantiation/Templ.cppm
--precompile -o %t/Templ.pcm
+// RUN: %clang -std=c++20 %S/Inputs/module-transtive-instantiation/bar.cppm
--precompile -fprebuilt-module-path=%t -o %t/bar.pcm
+// RUN: %clang -std=c++20 -fprebuilt-module-path=%t %s -c -Xclang -verify
+
+import bar;
+int foo() {
+ // FIXME: It shouldn't be an error. Since the `G` is already imported in
bar.
+ return bar<int>(); //
expected-error@Inputs/module-transtive-instantiation/bar.cppm:5 {{definition of
'G' must be imported from module 'Templ' before it is required}}
+ // expected-note@-1 {{in instantiation of function
template specialization 'bar<int>' requested here}}
+ //
expected-note@Inputs/module-transtive-instantiation/Templ.cppm:3 {{definition
here is not reachable}}
+}
Index: clang/test/Modules/module-transtive-instantiation-2.cpp
===================================================================
--- /dev/null
+++ clang/test/Modules/module-transtive-instantiation-2.cpp
@@ -0,0 +1,11 @@
+// RUN: rm -rf %t
+// RUN: mkdir -p %t
+// RUN: %clang -std=c++20 %S/Inputs/module-transtive-instantiation/Templ.cppm
--precompile -o %t/Templ.pcm
+// RUN: %clang -std=c++20 %S/Inputs/module-transtive-instantiation/bar.cppm
--precompile -fprebuilt-module-path=%t -o %t/bar.pcm
+// RUN: %clang -std=c++20 -fprebuilt-module-path=%t %s -c -Xclang -verify
+
+import bar;
+int foo() {
+ G<int> g; // expected-error {{declaration of 'G' must be imported from
module 'Templ' before it is required}}
+ return g(); //
expected-note@Inputs/module-transtive-instantiation/Templ.cppm:3 {{declaration
here is not visible}}
+}
Index: clang/test/Modules/Inputs/module-transtive-instantiation/bar.cppm
===================================================================
--- /dev/null
+++ clang/test/Modules/Inputs/module-transtive-instantiation/bar.cppm
@@ -0,0 +1,6 @@
+export module bar;
+import Templ;
+export template<class T>
+int bar() {
+ return G<T>()();
+}
Index: clang/test/Modules/Inputs/module-transtive-instantiation/Templ.cppm
===================================================================
--- /dev/null
+++ clang/test/Modules/Inputs/module-transtive-instantiation/Templ.cppm
@@ -0,0 +1,8 @@
+export module Templ;
+export template <class T>
+class G {
+public:
+ T operator()() {
+ return T();
+ }
+};
Index: clang/test/Modules/module-transtive-instantiation.cpp
===================================================================
--- /dev/null
+++ clang/test/Modules/module-transtive-instantiation.cpp
@@ -0,0 +1,13 @@
+// RUN: rm -rf %t
+// RUN: mkdir -p %t
+// RUN: %clang -std=c++20 %S/Inputs/module-transtive-instantiation/Templ.cppm --precompile -o %t/Templ.pcm
+// RUN: %clang -std=c++20 %S/Inputs/module-transtive-instantiation/bar.cppm --precompile -fprebuilt-module-path=%t -o %t/bar.pcm
+// RUN: %clang -std=c++20 -fprebuilt-module-path=%t %s -c -Xclang -verify
+
+import bar;
+int foo() {
+ // FIXME: It shouldn't be an error. Since the `G` is already imported in bar.
+ return bar<int>(); // expected-error@Inputs/module-transtive-instantiation/bar.cppm:5 {{definition of 'G' must be imported from module 'Templ' before it is required}}
+ // expected-note@-1 {{in instantiation of function template specialization 'bar<int>' requested here}}
+ // expected-note@Inputs/module-transtive-instantiation/Templ.cppm:3 {{definition here is not reachable}}
+}
Index: clang/test/Modules/module-transtive-instantiation-2.cpp
===================================================================
--- /dev/null
+++ clang/test/Modules/module-transtive-instantiation-2.cpp
@@ -0,0 +1,11 @@
+// RUN: rm -rf %t
+// RUN: mkdir -p %t
+// RUN: %clang -std=c++20 %S/Inputs/module-transtive-instantiation/Templ.cppm --precompile -o %t/Templ.pcm
+// RUN: %clang -std=c++20 %S/Inputs/module-transtive-instantiation/bar.cppm --precompile -fprebuilt-module-path=%t -o %t/bar.pcm
+// RUN: %clang -std=c++20 -fprebuilt-module-path=%t %s -c -Xclang -verify
+
+import bar;
+int foo() {
+ G<int> g; // expected-error {{declaration of 'G' must be imported from module 'Templ' before it is required}}
+ return g(); // expected-note@Inputs/module-transtive-instantiation/Templ.cppm:3 {{declaration here is not visible}}
+}
Index: clang/test/Modules/Inputs/module-transtive-instantiation/bar.cppm
===================================================================
--- /dev/null
+++ clang/test/Modules/Inputs/module-transtive-instantiation/bar.cppm
@@ -0,0 +1,6 @@
+export module bar;
+import Templ;
+export template<class T>
+int bar() {
+ return G<T>()();
+}
Index: clang/test/Modules/Inputs/module-transtive-instantiation/Templ.cppm
===================================================================
--- /dev/null
+++ clang/test/Modules/Inputs/module-transtive-instantiation/Templ.cppm
@@ -0,0 +1,8 @@
+export module Templ;
+export template <class T>
+class G {
+public:
+ T operator()() {
+ return T();
+ }
+};
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
