sammccall added inline comments.

================
Comment at: clang-tools-extra/clangd/XRefs.cpp:1388
+      TargetsInMainFile.insert(ID);
+      // Not all symbols can be referenced from outside (e.g. function-locals).
+      // TODO: we could skip TU-scoped symbols here (e.g. static functions) if
----------------
sammccall wrote:
> This is a nice optimization.
> Mention it in the patch description?
Oops, it came from elsewhere!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116043/new/

https://reviews.llvm.org/D116043

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to