curdeius added a comment.

Please review the descriptions.
Looks good, but I'm wondering if there are better names for these options.
E.g. when `AlignConsecutiveMacrosIgnoreMax` is true, then 
`AlignConsecutiveMacrosMinWidth` is not minimum width, but required/fixed width 
except for long macro names.



================
Comment at: clang/docs/ClangFormatStyleOptions.rst:547-550
+  Macros beyond ``AlignConsecutiveMacrosMinWidth`` break the
+  ConsecutiveMacroAlignment streak, When used in conjuction
+  With ``AlignConsecutiveMacrosMinWidth`` this allows longer macros to
+  not cause shorter macros to align.
----------------
Please add full stops at the end of sentences and fix capitals (like in With). 
(in Format.h of course and regenerate)
Commenting here as it's easier to see the end result.
Please check descriptions of other options too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112019/new/

https://reviews.llvm.org/D112019

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to