steakhal accepted this revision.
steakhal added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: clang/unittests/StaticAnalyzer/CallDescriptionTest.cpp:24-28
+static_assert(
+ std::is_constructible<CallDescriptionMap<bool>,
+ decltype(std::declval<ArgsContainer>().begin()),
+ decltype(std::declval<ArgsContainer>().end())>(),
+ "should be range constructible");
----------------
I'm not even sure we need this assertion though.
================
Comment at: clang/unittests/StaticAnalyzer/CallDescriptionTest.cpp:38
public:
ResultMap(std::initializer_list<std::pair<CallDescription, bool>> Data)
: Found(0),
----------------
Maybe the `ResultMap` should also follow this and declare the ctor overload.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D115934/new/
https://reviews.llvm.org/D115934
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
