vtjnash added a comment. Thanks! I will work on making those changes
================ Comment at: clang-tools-extra/test/clang-tidy/CTTestTidyModule.cpp:24-25 + + //void registerMatchers(ast_matchers::MatchFinder *Finder) override; + //void check(const ast_matchers::MatchFinder::MatchResult &Result) override; + ---------------- aaron.ballman wrote: > Shouldn't these functions be overloaded? We don't need it to be particularly > functional, but the plugin should demonstrate that it works and can be run by > clang-tidy (not just loaded and listed as a check). I figured that is guaranteed by the C++ linker, if it can successfully list the check, so I didn't think it seemed essential to test for that also. I put these here mostly just to help anyone copying the file to getting started with adopting it to their use case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111100/new/ https://reviews.llvm.org/D111100 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
