nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land.
LGTM In D115804#3195158 <https://reviews.llvm.org/D115804#3195158>, @spatel wrote: > In D115804#3195002 <https://reviews.llvm.org/D115804#3195002>, @nikic wrote: > >> Looks reasonable. Making float to int cast well defined is exactly why these >> intrinsics exist. Should we also drop the "string-float-cast-overflow" >> attribute, as UB is now prevented in a different way? > > Yes, that sounds like a good enhancement. The only in-tree use of the > attribute is in DAGCombiner. Make that a follow-up patch or two since it > crosses into LLVM? Followup sounds good. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115804/new/ https://reviews.llvm.org/D115804 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
