aaron.ballman added a comment.

In D113917#3193374 <https://reviews.llvm.org/D113917#3193374>, @ymandel wrote:

> Aaron - agreed on the points about `StringRef` vs `std::string`. But, before 
> I make that change, what did you think of moving to a more general method 
> `getMatcherSpec` that returns an object? That object will provide the name 
> (for now) and other data in the future (like the enum we discussed in the RFC 
> thread)?

I think that's a reasonable approach!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113917/new/

https://reviews.llvm.org/D113917

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to