luna marked an inline comment as done. luna added a comment. thanks for review!
Also in the previous reply, I forgot to mention I removed the the line `assert ((VTP.FuncVI) && "VTP.FuncVI must be nullptr` after finding existing references doesn't guarantee that [1], and `mustBeUnreachableFunction` will return false if an empty VI is passed in anyway. I'll run a ninja check (may take a while) and then push this. [1] For field `VirtFuncOffset::FuncVI`, there are `if` and `assertions` about empty value (e.g., https://github.com/llvm/llvm-project/blob/main/llvm/lib/AsmParser/LLParser.cpp#L7834) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115648/new/ https://reviews.llvm.org/D115648 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
