sammccall added a comment. In D115425#3190418 <https://reviews.llvm.org/D115425#3190418>, @nridge wrote:
> The patch is failing to build for me locally, with > `clang-tools-extra/clangd/ConfigFragment.h:100:10: fatal error: > 'ConfigFragment.gen.h' file not found`. I did re-run cmake and the error > persists. Is there another step I'm missing? You're not, sorry. It should be `#include "ConfigFragment.inc"`. (I renamed the generated file and it kept working for me locally because cmake doesn't clean up the old one). I had a discussion with @kadircet about this, we're not sure whether it factors out enough to be better/simpler overall. (Hand-written ConfigFragment + ConfigYAML + docs, vs table + generator + stubs of ConfigFragment + ConfigYAML + docs). Any thoughts? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115425/new/ https://reviews.llvm.org/D115425 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
