Author: Shilei Tian Date: 2021-12-13T16:31:04-05:00 New Revision: d6449d0d08222cbe0789cd67091f27d2061e7f9e
URL: https://github.com/llvm/llvm-project/commit/d6449d0d08222cbe0789cd67091f27d2061e7f9e DIFF: https://github.com/llvm/llvm-project/commit/d6449d0d08222cbe0789cd67091f27d2061e7f9e.diff LOG: Revert "[NFC][Clang][OpenMP] Use switch-case statement to process clauses of atomic directive" This reverts commit 5c23acbc023fbb9fdc6c56f4d2212ecb0432874e. Added: Modified: clang/lib/Sema/SemaOpenMP.cpp Removed: ################################################################################ diff --git a/clang/lib/Sema/SemaOpenMP.cpp b/clang/lib/Sema/SemaOpenMP.cpp index 3d2e04b7752c7..9672b0ac60a84 100644 --- a/clang/lib/Sema/SemaOpenMP.cpp +++ b/clang/lib/Sema/SemaOpenMP.cpp @@ -10934,11 +10934,9 @@ StmtResult Sema::ActOnOpenMPAtomicDirective(ArrayRef<OMPClause *> Clauses, OpenMPClauseKind MemOrderKind = OMPC_unknown; SourceLocation MemOrderLoc; for (const OMPClause *C : Clauses) { - switch (C->getClauseKind()) { - case OMPC_read: - case OMPC_write: - case OMPC_update: - case OMPC_capture: { + if (C->getClauseKind() == OMPC_read || C->getClauseKind() == OMPC_write || + C->getClauseKind() == OMPC_update || + C->getClauseKind() == OMPC_capture) { if (AtomicKind != OMPC_unknown) { Diag(C->getBeginLoc(), diag::err_omp_atomic_several_clauses) << SourceRange(C->getBeginLoc(), C->getEndLoc()); @@ -10948,13 +10946,12 @@ StmtResult Sema::ActOnOpenMPAtomicDirective(ArrayRef<OMPClause *> Clauses, AtomicKind = C->getClauseKind(); AtomicKindLoc = C->getBeginLoc(); } - break; } - case OMPC_seq_cst: - case OMPC_acq_rel: - case OMPC_acquire: - case OMPC_release: - case OMPC_relaxed: { + if (C->getClauseKind() == OMPC_seq_cst || + C->getClauseKind() == OMPC_acq_rel || + C->getClauseKind() == OMPC_acquire || + C->getClauseKind() == OMPC_release || + C->getClauseKind() == OMPC_relaxed) { if (MemOrderKind != OMPC_unknown) { Diag(C->getBeginLoc(), diag::err_omp_several_mem_order_clauses) << getOpenMPDirectiveName(OMPD_atomic) << 0 @@ -10965,10 +10962,6 @@ StmtResult Sema::ActOnOpenMPAtomicDirective(ArrayRef<OMPClause *> Clauses, MemOrderKind = C->getClauseKind(); MemOrderLoc = C->getBeginLoc(); } - break; - } - default: - llvm_unreachable("unknown clause is encountered"); } } // OpenMP 5.0, 2.17.7 atomic Construct, Restrictions _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
