dblaikie added inline comments.

================
Comment at: clang/test/CodeGenCXX/debug-info-access.cpp:28
 
+class C {
+public:
----------------
shchenz wrote:
> Will we generate a redundant flag if we define a private type in the class or 
> a public type in the struct/union? Maybe we could add a case for that too.
How',s this compare to member variables? Do we always put the access level on 
members even when it's the default? Perhaps the Flag handling code could be 
generalized and used between both these cases & if one of them gets fixed in 
favor of not explicitly specifying the default, both would benefit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115503/new/

https://reviews.llvm.org/D115503

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to