dblaikie added a comment. Generally sounds OK to me - this should be submitted as two separate patches. The LLVM part first, followed by the Clang part (since they can be separated they should be, and I guess the order doesn't matter too much (since the new IR that Clang's generating won't be invalid/break LLVM, it'll just be unused until the LLVM part is submitted).
I probably wouldn't bother adding the helper functions for "getParentDecl" to DeclCXX.h since there's only one use - if they provide a bunch of cleanup to existing callers, then maybe - otherwise just inlining the logic into the one call site is probably the right thing to do at the moment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115503/new/ https://reviews.llvm.org/D115503 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
