Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land.
LGTM! I agree according to the OpenCL programming model attributes `internal spir_kernel` together on the same function create a contradiction because kernel functions are expected to have global visibility. Adding @AlexeySachkov who has reported the same issue earlier elsewhere. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115523/new/ https://reviews.llvm.org/D115523 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
