ymandel added inline comments.
================ Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:31 +/// states of its predecessor basic blocks. +TypeErasedDataflowAnalysisState computeBlockInputState( + std::vector<llvm::Optional<TypeErasedDataflowAnalysisState>> &BlockStates, ---------------- should this be declared in the header? If not, please mark static. ================ Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:62 +/// `Block`. +TypeErasedDataflowAnalysisState transferBlock( + std::vector<llvm::Optional<TypeErasedDataflowAnalysisState>> &BlockStates, ---------------- Please declare this function in the header. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115235/new/ https://reviews.llvm.org/D115235 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
