aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from some small nits.
================ Comment at: clang-tools-extra/docs/clang-tidy/checks/misc-unconventional-assign-operator.rst:12 + * The assignment may be from the class type by value, const lvalue + reference, or non-const rvalue reference, or from a completely different + type (e.g. ``int``). ---------------- ================ Comment at: clang-tools-extra/test/clang-tidy/checkers/misc-unconventional-assign-operator.cpp:131 + +// Check that no false positives are issued when using type aliases +struct TypeAlias { ---------------- Can you also add tests which use `typedef` instead of `using`? (They should just work as-is) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114197/new/ https://reviews.llvm.org/D114197 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits