jansvoboda11 added inline comments.
================
Comment at:
clang/include/clang/Tooling/DependencyScanning/DependencyScanningFilesystem.h:49
- /// running out of file descriptors.
+ /// mismatching size of the file.
static CachedFileSystemEntry createFileEntry(StringRef Filename,
llvm::vfs::FileSystem &FS,
----------------
In the implementation of this function we get
`std::unique_ptr<llvm::vfs::File>` from the underlying filesystem. When that
goes out of scope, the file descriptor will be closed immediately. How did
copying contents into memory prevent running out of file descriptors? @arphaman
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D115043/new/
https://reviews.llvm.org/D115043
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
