dexonsmith added a comment. In D115254#3176564 <https://reviews.llvm.org/D115254#3176564>, @jamesfarrell wrote:
> Only change from previous attempt is to call rtrim() on the output of the > commands in the unit tests, since the new version parsing code fails if there > are leftover characters like \n. My only comment is on the commit message, which ideally would be a bit easier to get information from: - the summary line is very very long; can you cut it down, and put more in the body? - it'd be great to link directly to the commit that's being reapplied as well (both the most recent and the original) E.g., something like this, but feel free to reword / add more info / etc: Reapply "Use VersionTuple for parsing versions in Triple" (v3) Revert SHA1-1, reapplying SHA1-2 after fixing unit tests. The only change is to call rtrim() on the output of the commands in the unit tests, since the new version parsing code fails if there are leftover characters like `\n`. The original commit message (from SHA1-3) follows: Use VersionTuple for parsing versions in Triple. This makes it possible to distinguish between "16" and "16.0" after parsing, which previously was not possible. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115254/new/ https://reviews.llvm.org/D115254 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
