Anastasia added a comment.

Do you think we could add any test for this change?


================
Comment at: lib/CodeGen/BackendUtil.cpp:657
@@ -627,2 +656,3 @@
 
+
 bool EmitAssemblyHelper::AddEmitPasses(BackendAction Action,
----------------
Remove the empty line please

================
Comment at: lib/CodeGen/CodeGenAction.cpp:169
@@ +168,3 @@
+      std::function<bool(llvm::Module*)>
+        LinkCallBack = [=](llvm::Module *M)->bool {
+        // Link LinkModule into this module if present, preserving its 
validity.
----------------
Is there any reason for having this as a callback now?

Could we just add a call to prelink passes here above instead without modifying 
much the original flow?


http://reviews.llvm.org/D20681



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to