cor3ntin added a comment. In D111400#3165668 <https://reviews.llvm.org/D111400#3165668>, @hubert.reinterpretcast wrote:
> In D111400#3164301 <https://reviews.llvm.org/D111400#3164301>, @cor3ntin > wrote: > >> If the issue is regarding the support and extension warning in C++20 and >> older modes, it's something I can address by conserving the status quo in >> older versions. > > I think preserving the status quo in older modes is fine. > >> If the ask is a more involved modification of how clang does SFINAE in >> general, i don't think that i can take that on. > > As long as this patch isn't making a change to the older modes, then there's > nothing it's doing that requires special attention of the "disable if > checking for SFINAE purposes" variety. Somehow I missed that message, oups I will make non literal ill-formed in 20. I think labels can be left as is. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111400/new/ https://reviews.llvm.org/D111400 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
