owenpan added a comment.

In D115064#3170615 <https://reviews.llvm.org/D115064#3170615>, @curdeius wrote:

> Maybe using `llvm::SmallVector` with some well-thought (data-based) static 
> number of elements would be better here, WDYT?

I tend to agree as LLVM style 
<https://llvm.org/docs/ProgrammersManual.html#picking-the-right-data-structure-for-a-task>
 prefers `SmallVector` to `vector`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115064/new/

https://reviews.llvm.org/D115064

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to