steakhal added a comment. In D114454#3162490 <https://reviews.llvm.org/D114454#3162490>, @stevewan wrote:
>> setting a bunch of target triples and letting gtest to run each one to see >> if it still passes on all triples. > > Did you mean adding all the triples that we're interested in to > `allTestClangConfigs()`? If so, do you have a list in mind? Sorry if this is > a dumb question, I'm not very familiar with CSA and parameterized gtest. Yes. I don't know any specific, but we could pick a couple of esoteric targets where integrals differ significantly from what we have on `x86_64`. That said, I would test for `i686-pc-windows-msvc`, `i686-apple-darwin9`, `x86_64-apple-darwin9`, `x86_64-scei-ps4`, `x86_64-windows-msvc`, `x86_64-unknown-linux`, `x86_64-apple-macosx`, `x86_64-apple-ios14.0`, `wasm32-unknown-unknown`, `wasm64-unknown-unknown`, `thumb-pc-win32`, `sparc64-none-openbsd`, `sparc-none-none`, `riscv64-unknown-linux`, `ppc64-windows-msvc`, `powerpc-ibm-aix`, `powerpc64-ibm-aix`, `s390x-ibm-zos`, `armv7-pc-windows-msvc`, `aarch64-pc-windows-msvc`, `xcore-xmos-elf`. Please note that I've just grepped for the triples and picked some interesting-sounding ones. I did nothing scientific. We could change this in the future. About the content of the test, I think it looks good. It would be nice to have the test case fixed, instead of skipping it but I'm not expecting you to get into the details of doing that. It's not critical. ================ Comment at: clang/unittests/StaticAnalyzer/SValTest.cpp:152 + if (skipOnPPC32AIX(#NAME)) \ + return; \ + runCheckerOnCodeWithArgs<add##NAME##SValCollector>( \ ---------------- Please use `GTEST_SKIP() << "on powerpc-ibm-aix int and long has the same bitwidth"; return;` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114454/new/ https://reviews.llvm.org/D114454 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
