rtrieu added inline comments.
================
Comment at: clang/test/Modules/odr_hash.cpp:4288
S<X> s;
+// expected-error@first.h:* {{'ParameterTest::S::Foo' has different
definitions in different modules; definition in module 'FirstModule' first
difference is 1st parameter with name 'aaaa'}}
+// expected-note@second.h:* {{but in 'SecondModule' found 1st parameter with
name 'asdf'}}
----------------
krisb wrote:
> I'm not sure what was the original intent of this test (i.e. whether it
> intentionally tests the fact that there is no error on an uninstantiated
> static member function). As well as it doesn't clear to me what is the role
> of the unused typedef here, but it starts triggering the error because of
> redecls() call on isReferenced() added by this patch.
I've checked out the ODR Hashing versus the other cases. The new error is in
line with the other behavior. Having this new error is okay.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114382/new/
https://reviews.llvm.org/D114382
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
