ymandel added a comment.

Looks good, but why split the test into its own directory? I see that the 
implementation file is in clang/lib/Analysis and, in general, the lib and 
unittest directories are often flatter than the corresponding include 
directories. Maybe just put it directly into unittests/Analysis?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114721/new/

https://reviews.llvm.org/D114721

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to