aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
LGTM, with a few small nits. It'd be nice to update the patch summary with more information about why the option is needed. ================ Comment at: clang-tools-extra/docs/ReleaseNotes.rst:122 +- :doc:`cppcoreguidelines-narrowing-conversions <clang-tidy/checks/cppcoreguidelines-narrowing-conversions>` check now supports a WarnOnIntegerToFloatingPointNarrowingConversion option to control whether to warn on narrowing integer to floating-point conversions. + ---------------- Can you add backticks around `WarnOnIntegerToFloatingPointNarrowingConversion` so it gets highlighted properly, and reflow to the usual 80-col limit (it's fine to ignore it when links get too long, but not fine for a whole paragraph). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112881/new/ https://reviews.llvm.org/D112881 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
