Fznamznon marked an inline comment as not done.
Fznamznon added inline comments.
================
Comment at: clang/lib/Sema/SemaSYCL.cpp:68-75
+ bool ErrorFound = false;
+ if (isZeroSizedArray(*this, TypeToCheck)) {
+ SYCLDiagIfDeviceCode(UsedAt, diag::err_sycl_zero_array_size);
+ ErrorFound = true;
+ }
+ // Checks for other types can also be done here.
+ if (ErrorFound) {
----------------
bader wrote:
>
I'm not sure about this suggestion. I've made this place this way so It is easy
to extend it to diagnose other types (for example variable length arrays). Is
it ok if I leave it as is?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114080/new/
https://reviews.llvm.org/D114080
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
