labrinea accepted this revision. labrinea added a comment. This revision is now accepted and ready to land.
Looks like you've addressed Oliver's comments. I don't have any new suggestions from my end. Just make sure you've removed the test xfail before merging. ================ Comment at: clang/test/Driver/darwin-ld-lto.c:2 // REQUIRES: system-darwin - +// XFAIL: * // Check that ld gets "-lto_library". ---------------- Seems accidental. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112420/new/ https://reviews.llvm.org/D112420 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits