mclow.lists added a comment.

In general, I'm OK with this - but I'm concerned about that there's not really 
any provision for the case where `strerror_r` does not exist.

Also, there's no reason to have a thread local static array here, if you're 
going to immediately copy it into a `std::string`.


http://reviews.llvm.org/D20903



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to