kbobyrev updated this revision to Diff 388816.
kbobyrev marked 2 inline comments as done.
kbobyrev added a comment.
Address review comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114287/new/
https://reviews.llvm.org/D114287
Files:
clang-tools-extra/clangd/IncludeCleaner.cpp
clang-tools-extra/clangd/unittests/IncludeCleanerTests.cpp
Index: clang-tools-extra/clangd/unittests/IncludeCleanerTests.cpp
===================================================================
--- clang-tools-extra/clangd/unittests/IncludeCleanerTests.cpp
+++ clang-tools-extra/clangd/unittests/IncludeCleanerTests.cpp
@@ -97,6 +97,10 @@
"inline void ^foo() {}",
"void bar() { foo(); }",
},
+ {
+ "int ^foo(char); int ^foo(float);",
+ "template<class T> int x = foo(T{});",
+ },
// Static function
{
"struct ^X { static bool ^foo(); }; bool X::^foo() {}",
Index: clang-tools-extra/clangd/IncludeCleaner.cpp
===================================================================
--- clang-tools-extra/clangd/IncludeCleaner.cpp
+++ clang-tools-extra/clangd/IncludeCleaner.cpp
@@ -13,6 +13,7 @@
#include "SourceCode.h"
#include "support/Logger.h"
#include "support/Trace.h"
+#include "clang/AST/ExprCXX.h"
#include "clang/AST/RecursiveASTVisitor.h"
#include "clang/Basic/SourceLocation.h"
#include "clang/Lex/HeaderSearch.h"
@@ -104,6 +105,13 @@
return true;
}
+ // When the overload is not resolved yet, mark all candidates as used.
+ bool VisitOverloadExpr(OverloadExpr *E) {
+ for (const auto *ResolutionDecl : E->decls())
+ add(ResolutionDecl);
+ return true;
+ }
+
private:
using Base = RecursiveASTVisitor<ReferencedLocationCrawler>;
Index: clang-tools-extra/clangd/unittests/IncludeCleanerTests.cpp
===================================================================
--- clang-tools-extra/clangd/unittests/IncludeCleanerTests.cpp
+++ clang-tools-extra/clangd/unittests/IncludeCleanerTests.cpp
@@ -97,6 +97,10 @@
"inline void ^foo() {}",
"void bar() { foo(); }",
},
+ {
+ "int ^foo(char); int ^foo(float);",
+ "template<class T> int x = foo(T{});",
+ },
// Static function
{
"struct ^X { static bool ^foo(); }; bool X::^foo() {}",
Index: clang-tools-extra/clangd/IncludeCleaner.cpp
===================================================================
--- clang-tools-extra/clangd/IncludeCleaner.cpp
+++ clang-tools-extra/clangd/IncludeCleaner.cpp
@@ -13,6 +13,7 @@
#include "SourceCode.h"
#include "support/Logger.h"
#include "support/Trace.h"
+#include "clang/AST/ExprCXX.h"
#include "clang/AST/RecursiveASTVisitor.h"
#include "clang/Basic/SourceLocation.h"
#include "clang/Lex/HeaderSearch.h"
@@ -104,6 +105,13 @@
return true;
}
+ // When the overload is not resolved yet, mark all candidates as used.
+ bool VisitOverloadExpr(OverloadExpr *E) {
+ for (const auto *ResolutionDecl : E->decls())
+ add(ResolutionDecl);
+ return true;
+ }
+
private:
using Base = RecursiveASTVisitor<ReferencedLocationCrawler>;
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
