salman-javed-nz marked 4 inline comments as done. salman-javed-nz added a comment.
I reverted my changes to do with the invalid character substitution. Doing something akin to `isAllowedInitiallyIDChar()` and `isAllowedIDChar()` in Lexer.cpp will require converting from `char*` to `UTF32*`. Windows complicates things by using its own code page (typically Windows-1252). Will require a lot of careful consideration to implement correctly. Changing this was never part of the PR's scope, so I have reverted it for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114149/new/ https://reviews.llvm.org/D114149 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
